prefect icon indicating copy to clipboard operation
prefect copied to clipboard

handle UNC paths for windows

Open zzstoatzz opened this issue 1 year ago • 3 comments

closes https://github.com/PrefectHQ/prefect/issues/15971

I'm happy to remove this new CI job I used to repro, but it wont run unless we change the filesystem utils anyways

zzstoatzz avatar Nov 13 '24 19:11 zzstoatzz

CodSpeed Performance Report

Merging #16005 will not alter performance

Comparing path-to-unc (a35f3cb) with main (8758666)

Summary

✅ 3 untouched benchmarks

codspeed-hq[bot] avatar Nov 13 '24 19:11 codspeed-hq[bot]

@zzstoatzz sorry just thinking through the workflow filters again -- do you think we benefit if it runs on core dependency changes (requirements.txt and requirements-client.txt) as well?

cicdw avatar Nov 13 '24 20:11 cicdw

@zzstoatzz sorry just thinking through the workflow filters again -- do you think we benefit if it runs on core dependency changes (requirements.txt and requirements-client.txt) as well?

to be safe I think that'd make sense, considering its not an expensive CI job. added in 591c3b5

zzstoatzz avatar Nov 13 '24 20:11 zzstoatzz