prefect icon indicating copy to clipboard operation
prefect copied to clipboard

Edit of development section docs

Open stellardave opened this issue 9 months ago • 2 comments

Updated the Development section. Key edits include:

  • Cutting overexplanations
  • Typo fixes
  • Being more authoritative and actionable
  • Moving to second person (you) instead of first person plural (we)

stellardave avatar May 05 '24 14:05 stellardave

Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
Latest commit 453c9cb3dad242312bca90c5270be89c8600c9e8

netlify[bot] avatar May 05 '24 14:05 netlify[bot]

Thanks for the improvements! Incorporated.

stellardave avatar May 05 '24 22:05 stellardave

Man, in an attempt to merge some docs changes on main in this PR I really messed it up and I'm not quite sure how to un-mess it up, my apologies. Anyone know how to get this back to the state it was in prior to 10e9d56?

billpalombi avatar May 16 '24 14:05 billpalombi

No worries, it happens. I'm not a git wizard though, so open to if anyone on your team has any ideas.

On Thu, May 16, 2024 at 7:46 AM Bill Palombi @.***> wrote:

Man, in an attempt to merge some docs changes on main in this PR I really messed it up and I'm not quite sure how to un-mess it up, my apologies. Anyone know how to get this back to the state it was in prior to 10e9d56 https://github.com/PrefectHQ/prefect/pull/13247/commits/10e9d56906d11f815632f9d1b8b8f1622c9d5536 ?

— Reply to this email directly, view it on GitHub https://github.com/PrefectHQ/prefect/pull/13247#issuecomment-2115449796, or unsubscribe https://github.com/notifications/unsubscribe-auth/A76PPBM3NSXUCNAFTXFXLI3ZCTBCTAVCNFSM6AAAAABHHY7N42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGQ2DSNZZGY . You are receiving this because you authored the thread.Message ID: @.***>

-- Dave Nuñez

Principal

Stellar Docs 4158139912 <8143801358> @.***

stellardave avatar May 17 '24 01:05 stellardave

Well, that made it worse. I'll try and rebuild this PR with cherry-pick, the data is still here, just need to apply it in the right order.

bunchesofdonald avatar May 17 '24 13:05 bunchesofdonald

Okay, it's back @billpalombi . I did have some gnarly git conflicts, I tried to do my best to get the right one, but we should go back through this PR and make sure it's what we want.

@stellardave I 'force-pushed' this branch a lot, so if you want to change it you'll want to do a git pull before making any changes, or if you already have staged changes you'll want to pull with rebase.

bunchesofdonald avatar May 17 '24 14:05 bunchesofdonald

Thanks a ton @bunchesofdonald!

This looks good to me @stellardave, but worth getting your eyes on it once more before we merge it.

billpalombi avatar May 17 '24 15:05 billpalombi

Thanks @bunchesofdonald!

Looks good to me. @billpalombi I'll review after it lands to make doubly sure it looks okay.

stellardave avatar May 17 '24 16:05 stellardave