prefect icon indicating copy to clipboard operation
prefect copied to clipboard

Standardize work pool name as Process

Open discdiver opened this issue 1 year ago • 5 comments

Closes #10842

Updates docs and server instance UI to refer to Process work pool instead of subprocess.

Most places it already was Process (e.g. CLI, type in UI, most docs).

Example

Checklist

  • [X] This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • [ ] If this pull request adds new functionality, it includes unit tests that cover the changes
  • [X] This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • [ ] This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • [ ] This pull request includes helpful docstrings.
  • [ ] If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

discdiver avatar Apr 30 '24 18:04 discdiver

Deploy Preview for prefect-docs-preview ready!

Name Link
Latest commit 49b6a3d7c9069aafb81e858b6d92cefe0ce7242b
Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/663155483dd8070008137456
Deploy Preview https://deploy-preview-13176--prefect-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 30 '24 18:04 netlify[bot]

I think it may need to be updated here as well: https://github.com/PrefectHQ/prefect/blob/ae9351fa30a82ecbf06f5c9a8f43b4a5740f41e9/src/prefect/workers/process.py#L145

@desertaxle can you think of anywhere else we might need to update this?

serinamarie avatar Apr 30 '24 20:04 serinamarie

I think it may need to be updated here as well:

https://github.com/PrefectHQ/prefect/blob/ae9351fa30a82ecbf06f5c9a8f43b4a5740f41e9/src/prefect/workers/process.py#L145

@desertaxle can you think of anywhere else we might need to update this?

Yeah, the spot you linked is the source of truth that the metadata is derived from, so changing it there will propagate to the collection registry.

desertaxle avatar Apr 30 '24 20:04 desertaxle

Why standardize on "Process" instead of "Local Subprocess"? The latter is more descriptive.

@billpalombi - I hear them referred to much more frequently as a Process worker and Process work pool, so trying to minimize disruption by keeping that naming. Most places it is already referred to as "Process" within Prefect (see screenshots in the issue) - e.g. the type of work pool is "Process", we just display it a few places as Subprocess.

Open to revisiting, but I think it would be felt as a bigger change by users to move to Subprocess.

discdiver avatar Apr 30 '24 20:04 discdiver

Thank you @serinamarie and @desertaxle - updated.

discdiver avatar Apr 30 '24 20:04 discdiver