prefect icon indicating copy to clipboard operation
prefect copied to clipboard

Allow creation of blocks with underscores in the block name

Open masonmenges opened this issue 1 year ago • 1 comments

First check

  • [X] I added a descriptive title to this issue.
  • [X] I used the GitHub search to find a similar request and didn't find it.
  • [X] I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the current behavior

Prefect only supports block names with lowercase alphanumeric characters and dashes other special characters are not supported and results in an error. block-name

block_name

Describe the proposed behavior

Allow block names/slugs to be created with underscores to fit naming other naming conventions.

Example Use

No response

Additional context

No response

masonmenges avatar Jan 23 '24 19:01 masonmenges

I am not sure we want to accept other characters besides lowercase alphanumeric characters and hyphens for things like block document names - we explicitly enforce this here


to surface sync discussion, this request was made because a user had a great number of secrets in Prefect 1 where underscores were allowed, which makes it a bit inconvenient to adopt the new Secret name requirements

At this time, we will keep this open and see if other users express the same request

zzstoatzz avatar Jan 29 '24 18:01 zzstoatzz

@zzstoatzz is there any history here around a real, principled reason we should not support this? barring that, I think we should just sketch out implementation to ensure we're not going to break a bunch of things and accept it.

WillRaphaelson avatar Feb 28 '24 17:02 WillRaphaelson