marvin icon indicating copy to clipboard operation
marvin copied to clipboard

Allow to connect from localhost without SSL

Open jedihugo opened this issue 1 year ago • 2 comments

First check

  • [X] I added a descriptive title to this issue.
  • [X] I used the GitHub search to look for a similar issue and didn't find it.
  • [X] I searched the Marvin documentation for this feature.

Describe the current behavior

Currently when running from localhost without SSL it has issues connecting to Open AI

raise ClientConnectorCertificateError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorCertificateError: Cannot connect to host api.openai.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)')]

raise error.APIConnectionError("Error communicating with OpenAI") from e
openai.error.APIConnectionError: Error communicating with OpenAI

Describe the proposed behavior

It should allow running from localhost without SSL. It seems that marvin is using aiohttp. So perhaps can set SSL to false?

Example Use

No response

Additional context

No response

jedihugo avatar Jul 16 '23 15:07 jedihugo

Hey @jedihugo, should be simple enough for us to fix. That layer wraps the OpenAI SDK so we should be able to enable passing those kwargs down.

aaazzam avatar Jul 16 '23 23:07 aaazzam

Hi @aaazzam Running from localhost seems to breaks in >=1.5.5.

adrianpdm avatar Nov 10 '23 10:11 adrianpdm