pretext icon indicating copy to clipboard operation
pretext copied to clipboard
verified publisher icon PreTeXtBook

HTML: adjust spacing of icons in footer

Open whaynes opened this issue 2 years ago • 4 comments

This pull request removes the width attribute on the PreTeXt logo in the page footer.

This width is preventing the footer's flexbox from distributing the PreTeXt, Runestone, and MathJax icons evenly.

whaynes avatar Sep 23 '23 20:09 whaynes

I am not seeing how this makes a difference in the footer, nor that it is not evenly spaced already:

https://pretextbook.org/examples/sample-article/html/derivatives.html

davidfarmer avatar Sep 23 '23 21:09 davidfarmer

I understand that flexbox's justify-content: space-around is supposed to distribute the items evenly with the left and right gaps half the size of the gaps between the items.

This is what I see with and without the width="100%". Maybe it is only a problem on Safari?  Will

On Sep 23, 2023, at 5:57 PM, David W. Farmer @.***> wrote:

I am not seeing how this makes a difference in the footer, nor that it is not evenly spaced already:

https://pretextbook.org/examples/sample-article/html/derivatives.html

— Reply to this email directly, view it on GitHub https://github.com/PreTeXtBook/pretext/pull/2075#issuecomment-1732417809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKSHIFSNUZLVQG6WK65HV3X35LNDANCNFSM6AAAAAA5ENPNQU. You are receiving this because you authored the thread.

whaynes avatar Sep 23 '23 22:09 whaynes

This is what I see with and without the width="100%". footers

This is what I see on my iPhone IMG_7919

whaynes avatar Sep 24 '23 02:09 whaynes

Where are we on this one? Spacing looks fine to me in Firefox and in Chrome, both wide ans mobile-skinny. Maybe we can ask for some Safari-testing on the -dev list to see if that is the real culprit.

I'm hesitant to think that editing the one SVG image directly is the solution here.

rbeezer avatar Apr 20 '24 17:04 rbeezer

In the current sample article, I see the icons equally spaced, with or without the "feedback" button.

So I suggest closing this. Please reopen and explain what I missed if this still seems to be a problem.

I tested in Firefox and Chrome.

davidfarmer avatar Jul 17 '24 02:07 davidfarmer

Thanks, @whaynes for your work on this.

Yes, I think this is OK, or perhaps only a problem on Safari (which won't be the first time). Please reopen this if you think it still needs further consideration.

rbeezer avatar Jul 17 '24 02:07 rbeezer

It's a problem I see consistently on my browser (Safari) that annoys me, but I can live with it.

whaynes avatar Jul 17 '24 03:07 whaynes