pretext icon indicating copy to clipboard operation
pretext copied to clipboard

embedded_sagecell.js should be `defer`

Open siefkenj opened this issue 2 years ago • 4 comments

There should be a defer tag on all Javascript that is not needed right away. I believe MathJax setup code is the only code that needs to be loaded before the page.

siefkenj avatar Feb 08 '22 01:02 siefkenj

Gave this a try for Sage Cells. After the page loads, the cells are not visible. But if I open (an unrelated) knowl, the cells all become visible.

@davidfarmer may be experimenting with JS right now, I see some hints in the console. I'll try again later.

rbeezer avatar Feb 08 '22 16:02 rbeezer

I am not doing anything with the JS (not the JS called by the dev branch).

On Tue, 8 Feb 2022, Rob Beezer wrote:

Gave this a try for Sage Cells. After the page loads, the cells are not visible. But if I open (an unrelated) knowl, the cells all become visible.

@davidfarmer may be experimenting with JS right now, I see some hints in the console. I'll try again later.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you werementioned.[AABTULERS6TEWYAHD5G5PX3U2FBSXA5CNFSM5NZBWGSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN 5WW2ZLOORPWSZGOHWH23SY.gif] Message ID: @.***>

davidfarmer avatar Feb 08 '22 17:02 davidfarmer

Darn. ;-) I'll post some console output once I get back to that branch.

rbeezer avatar Feb 08 '22 17:02 rbeezer

Console errors about knowlcare gone now. But behavior exists. I can post a smaple if requested.

rbeezer avatar Feb 08 '22 18:02 rbeezer

Adding @defer still makes Sage cells totally go away. I'm closing this and it can be reopened if there is interest.

rbeezer avatar May 05 '23 21:05 rbeezer