Presences icon indicating copy to clipboard operation
Presences copied to clipboard

feat(aniwatch): add regex to support alternative domains

Open MohammedBakr44 opened this issue 1 year ago • 5 comments

Description

Add regular expression matching to support alternative domains as the current presence only supports aniwatch.to which is blocked in some countries. The expression matches the string aniwatch followed by any prefix to support domains such as aniwatchtv.to, it also matches any TLD as I personally use aniwatch.nz.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

Before regex update

image_2024-02-17_10-42-43

After regex update

image_2024-02-17_10-49-12

image_2024-02-17_10-48-31

tested on aniwatch.nz and aniwatchtv.to

MohammedBakr44 avatar Feb 17 '24 09:02 MohammedBakr44

updated version to 1.0.3

MohammedBakr44 avatar Feb 17 '24 09:02 MohammedBakr44

image I would personally go with a regex such as aniwatch[a-z]*[.][a-z]{2,3} image

mallusrgreatv2 avatar Feb 17 '24 15:02 mallusrgreatv2

Any updates for this PR?

theusaf avatar Feb 23 '24 21:02 theusaf

Sorry about that. I noticed the issue with regex and decided to fix it later but got carried out in life. Now I applied a fix and tested it(Thanks to @mallusrgreatv2).

MohammedBakr44 avatar Mar 02 '24 19:03 MohammedBakr44

When your changes are ready, make sure to resolve merge conflicts and mark the PR as ready.

theusaf avatar Mar 04 '24 23:03 theusaf

Closing for inactivity. You may open a new PR after resolving the issues mentioned in this one.

theusaf avatar Mar 25 '24 22:03 theusaf