Presences icon indicating copy to clipboard operation
Presences copied to clipboard

feat(JoJo's Bizarre Encyclopedia): add new presence

Open wavpro opened this issue 2 years ago • 7 comments

Description

Added new presence for JoJo's Bizarre Encyclopedia (jojowiki.com and jojo-news.com). It displays activity on the mentioned sites.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected ![Screenshot](https://user-images.githubusercontent.com/31097540/184456148-6a188669-d767-403e-8e16-bf780e4fb1d2.jpg) ![Screenshot](https://user-images.githubusercontent.com/31097540/184456168-25bd57b7-7175-485d-9706-7217737be872.png) ![Screenshot](https://user-images.githubusercontent.com/31097540/184456302-9130f3ee-c66e-4b9f-b320-a4ebd0a734e1.jpg) ![Screenshot](https://user-images.githubusercontent.com/31097540/184456383-f771ed09-f1f9-43b7-87a2-478e07f26bf5.jpg)

wavpro avatar Aug 12 '22 23:08 wavpro

It seems to fail checks because of other presences, not mine. Github says my fork was fully up to date, can someone check this out?

wavpro avatar Aug 12 '22 23:08 wavpro

CI failed on your PR because you edited the presence. Delete the changes

EncryptedDev avatar Aug 12 '22 23:08 EncryptedDev

CI failed on your PR because you edited the presence. Delete the changes

How do I remove it from the pull request? It doesn't help editing since nothing has changed from the old version, just that there's a commit that says it's changed. I don't know why this happened, I didn't see these files included when committing.

wavpro avatar Aug 12 '22 23:08 wavpro

CI failed on your PR because you edited the presence. Delete the changes

How do I remove it from the pull request? It doesn't help editing since nothing has changed from the old version, just that there's a commit that says it's changed. I don't know why this happened, I didn't see these files included when committing.

Those files are from your yarn format, those two files has a little format errors that make them change when you run the commande. Rollback you commits to fix that

RisingSunLight42 avatar Aug 13 '22 01:08 RisingSunLight42

I've fixed the formatting error

wavpro avatar Aug 13 '22 09:08 wavpro

Undo the packagejson and yarnlock too

Bas950 avatar Aug 13 '22 10:08 Bas950

Undo the packagejson and yarnlock too

Done

wavpro avatar Aug 13 '22 11:08 wavpro

Undo the packagejson and yarnlock too

Done

Nope, package.lock and yarn.lock are still on this PR

EncryptedDev avatar Aug 13 '22 23:08 EncryptedDev

How would I remove them completely from the PR? I have made sure they're exactly the same as currently in the repo.

On Sun, Aug 14, 2022, 1:22 AM Rhys Rakoff @.***> wrote:

Undo the packagejson and yarnlock too

Done

Nope, package.lock and yarn.lock are still on this PR

— Reply to this email directly, view it on GitHub https://github.com/PreMiD/Presences/pull/6652#issuecomment-1214245328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHNIFRBGU64D4IC75R3Y4DLVZAU4HANCNFSM56NEC26Q . You are receiving this because you authored the thread.Message ID: @.***>

wavpro avatar Aug 13 '22 23:08 wavpro