refactor(VRV): change code structure and more
Description
Changelog
- Resolves #4809 by adding a iFrameRegExp in the metadata, forcing PreMid to get the right iframe for the video element
- Fix error on
presence.ts, currentTime and duration were not correctly getted. - Add five settings : multilanguage, Show Timestamps, Show Cover, Show Buttons, Show Search
- Add feature : display what user is searching if setting enabled
- Add feature : display cover of what the user is currently viewing if setting enabled
- Add feature : display buttons to series or episodes if setting enabled.
- Add feature : users can remove timestamps
- Refactoring the localization of the presence and adding 7 localized strings to it
- Refactoring the whole
presence.tsby removingif/elsein favor ofswitch/caseand redoing structure to avoid duplicate code.
Ask to change the author
@Bas950 I would like, if you're fine with that, adding me to author and you to contributor since I've edited almost everything in the presence. If you're fine with, I'll change the clientId at the top of the file and the metadata file, if not, I'll do nothing. ^^
Acknowledgements
- [x] I read the Presence Guidelines
- [x] I linted the code by running
yarn format - [x] The PR title follows the repo's commit conventions
Screenshots
Proof showing the creation/modification is working as expected
Context for the first screenshot : since the search can be done on every page of the website, if the setting to show search query is disabled, the presence will display what is displayed behind the research panel.
@Bas950 I would like, if you're fine with that, adding me to author and you to contributor since I've edited almost everything in the presence. If you're fine with, I'll change the clientId at the top of the file and the metadata file, if not, I'll do nothing. ^^
Feel free to switch as around as auther and contributor. clientId shouldn't need changing since it works... but for future maintainability maybe use imgur links for images and not the keys of the discord assets.
@Bas950 I would like, if you're fine with that, adding me to author and you to contributor since I've edited almost everything in the presence. If you're fine with, I'll change the clientId at the top of the file and the metadata file, if not, I'll do nothing. ^^
Feel free to switch as around as auther and contributor. clientId shouldn't need changing since it works... but for future maintainability maybe use imgur links for images and not the keys of the discord assets.
I'll switch to imgur link then, thanks!
Imgur links added and author/contributor swaped !
Very detailed description 🚀
Very detailed description 🚀
I prefer to detail to make the review easier for you since there's a lot of changes!