compose-material-dialogs
compose-material-dialogs copied to clipboard
Using getDisplayName function to get dayOfWeek name may not a good idea
By using getDisplayName to get dayOfWeek name in Chinese will get like this:
It's will show 星
all day, which in Chinese mean nothing, such as always show day
in English.
I know this getDisplayName is from jvm:
So I test from Avd android 7.0 - Android 12. Both like this, I also using my Mi 10u(Android 12) test it, of course I get same result.
I found a same issue in other project: incorrect result of dayOfWeek.getDisplayName(TextStyle.NARROW, Locale.getDefault())
Using TextStyle.SHORT
instead TextStyle.NARROW
will show right text.
I'm thinking about ability to inject the functionality from outside if necessary. Default function would be getDisplayName()
but it can be overriden by the code similar to the one here. It's obviously a bug in the Android implementation, so it shouldn't be fixed by this library. @vanpra wdyt?
I'm thinking about ability to inject the functionality from outside if necessary. Default function would be
getDisplayName()
but it can be overriden by the code similar to the one here. It's obviously a bug in the Android implementation, so it shouldn't be fixed by this library. @vanpra wdyt?
Yes. Although It not this library's problem, but may provide a function to set this paramter by user is a good idea.
What is the status of this issue? Already fixed?
What is the status of this issue? Already fixed?
I don't think so, But now compose already support Date Picker Dialog, You can try it.