NBomber icon indicating copy to clipboard operation
NBomber copied to clipboard

Published 20 hours ago • verified publisher icon PragmaticFlow

Add threshold for statistics

Open pavlogrushetsky opened this issue 2 years ago • 5 comments

This is a draft PR for https://github.com/PragmaticFlow/NBomber/issues/355 (Add threshold for statistics). The work is still in progress, and the PR is rather for review and conversation about the overall approach.

Some other things TODO:

  • [x] Implementing thresholds for DataTransferStats
  • [x] Implementing logic for displaying the thresholds status in the load test outputs
  • [ ] ~Specifying thresholds through the configuration files~
  • [ ] Adding comments to the new methods in the contracts
  • [ ] Covering the changes with the tests

I would appreciate any feedback on this draft implementation 🙇‍♂️.

pavlogrushetsky avatar May 15 '22 19:05 pavlogrushetsky

@AntyaDev One more question 😅 Would the following functionality make sense to you?:

  • [ ] Specifying thresholds through the configuration files

pavlogrushetsky avatar May 20 '22 19:05 pavlogrushetsky

"Specifying thresholds through the configuration files" - seems can be skipped for now :) I used to add such things iteratively.

AntyaDev avatar May 23 '22 06:05 AntyaDev

"Specifying thresholds through the configuration files" - seems can be skipped for now :) I used to add such things iteratively.

Great! Makes sense to me, thank you!

pavlogrushetsky avatar May 23 '22 07:05 pavlogrushetsky

Hi @pavlogrushetsky Any news?

AntyaDev avatar Jul 04 '22 19:07 AntyaDev

Hi @pavlogrushetsky Any news?

Oh, I've been busy recently, sorry. I'll try to push something this week.

pavlogrushetsky avatar Jul 05 '22 06:07 pavlogrushetsky