PyAPNs2
PyAPNs2 copied to clipboard
hyper dependency is no longer maintained
As of January, hyper is no longer maintained:
https://github.com/python-hyper/hyper/commit/b77e758f472f00b098481e3aa8651b0808524d84
The readme recommends switching to httpx
also hyper requires h2 <3.0, which causes problems using other libraries that need h2>=3.0.
I'm facing an issue using hypercorn.
My conflict was with Twisted and the http2 extras installed. (Twisted[http2]) Also h2
Also bothered by this...
I started looking into what it would take to port from hyper -> httpx, and it's not THAT bad, but, it does take some knowledge of the innerworkings of both packages.
Is anyone doing this? Now knowing hyper or httpx, I'm probably not the best person to do it, but, I do need it done . . . ;-)
Thoughts?
-Dave
Yes, I know, @CodeMonk specifically says https://github.com/CodeMonk/PyAPNs2/commit/a1a3d598a98c84317f60f2f5884760c57a1b8f56 is completely untested and dangerous, but if anybody would have means how to test it, it would be better if the patch was known.
I tested it, and declined the PR. Wasn't even close to a full solution. If anyone knows hyper or httpx, they could better evaluate how much the lift would be.
I may have some cycles to try to improve my port later.
@CodeMonk I have a proper testing environment (staging env with sandboxed apps to play with) and am willing to help, bcz we badly need it. What's the status on your PR? Why did you decline it?
FYI, found 2 forks where hyper was replaced with httpx: https://github.com/pocketlabs/PyAPNs2 https://github.com/karlwnw/PyAPNs2
Good find, @erwan-lemonnier ! Please do share your experience here if you try either of those. I took a look at the first link and the footprint appears to be reasonably small.
FYI, found 2 forks where hyper was replaced with httpx: https://github.com/pocketlabs/PyAPNs2
https://github.com/pocketlabs/PyAPNs2/commit/f1220b8e0b87caf08f3f3d6d3ab9146e75c90543 doesn’t let PyAPNs2 pass its test suite.
https://github.com/karlwnw/PyAPNs2
https://github.com/karlwnw/PyAPNs2/tree/feature/httpx seems like MUCH more invasive and the last commit is still marked as WIP.
ping @karlwnw & @kitdesai
https://github.com/CodeMonk/PyAPNs2/tree/feature/port-to-httpx is @CodeMonk's port.
https://github.com/chrigu/PyAPNs2/tree/feature/httpx is another port by @chrigu
Worth noting that several libraries using apns2 have switched to using https://github.com/Fatal1ty/aioapns , which only depends on h2,pyopenssl&pyjwt rather than httpx which has a large dependency tree (see https://www.wheelodex.org/projects/httpx/ ).
ping everyone , has any of these ports progressed at all?
@jayvdb I just made the parts working that I needed for my project and my port won't be developed any further.
And we replaced PyAPNs2 with aioapns, which required a bit of extra work to make sure threads are properly initialised but works really well with python >= 3.8
Any chance of a release?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
There is some progress at https://github.com/Pr0Ger/PyAPNs2/pull/149
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This is still an issue
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This is still an issue