PyAPNs2 icon indicating copy to clipboard operation
PyAPNs2 copied to clipboard

hyper dependency is no longer maintained

Open kevindice opened this issue 4 years ago • 26 comments

As of January, hyper is no longer maintained: https://github.com/python-hyper/hyper/commit/b77e758f472f00b098481e3aa8651b0808524d84

The readme recommends switching to httpx

kevindice avatar Mar 25 '21 17:03 kevindice

also hyper requires h2 <3.0, which causes problems using other libraries that need h2>=3.0. I'm facing an issue using hypercorn.

levy42 avatar Mar 26 '21 10:03 levy42

My conflict was with Twisted and the http2 extras installed. (Twisted[http2]) Also h2

kevindice avatar Mar 26 '21 16:03 kevindice

Also bothered by this...

thierryba avatar Apr 15 '21 13:04 thierryba

I started looking into what it would take to port from hyper -> httpx, and it's not THAT bad, but, it does take some knowledge of the innerworkings of both packages.

Is anyone doing this? Now knowing hyper or httpx, I'm probably not the best person to do it, but, I do need it done . . . ;-)

Thoughts?

-Dave

CodeMonk avatar Apr 27 '21 20:04 CodeMonk

Yes, I know, @CodeMonk specifically says https://github.com/CodeMonk/PyAPNs2/commit/a1a3d598a98c84317f60f2f5884760c57a1b8f56 is completely untested and dangerous, but if anybody would have means how to test it, it would be better if the patch was known.

mcepl avatar May 01 '21 18:05 mcepl

I tested it, and declined the PR. Wasn't even close to a full solution. If anyone knows hyper or httpx, they could better evaluate how much the lift would be.

I may have some cycles to try to improve my port later.

CodeMonk avatar May 03 '21 19:05 CodeMonk

@CodeMonk I have a proper testing environment (staging env with sandboxed apps to play with) and am willing to help, bcz we badly need it. What's the status on your PR? Why did you decline it?

erwan-lemonnier avatar Jun 03 '21 13:06 erwan-lemonnier

FYI, found 2 forks where hyper was replaced with httpx: https://github.com/pocketlabs/PyAPNs2 https://github.com/karlwnw/PyAPNs2

erwan-lemonnier avatar Jun 04 '21 13:06 erwan-lemonnier

Good find, @erwan-lemonnier ! Please do share your experience here if you try either of those. I took a look at the first link and the footprint appears to be reasonably small.

whardeman avatar Jun 04 '21 18:06 whardeman

FYI, found 2 forks where hyper was replaced with httpx: https://github.com/pocketlabs/PyAPNs2

https://github.com/pocketlabs/PyAPNs2/commit/f1220b8e0b87caf08f3f3d6d3ab9146e75c90543 doesn’t let PyAPNs2 pass its test suite.

https://github.com/karlwnw/PyAPNs2

https://github.com/karlwnw/PyAPNs2/tree/feature/httpx seems like MUCH more invasive and the last commit is still marked as WIP.

mcepl avatar Sep 14 '21 10:09 mcepl

ping @karlwnw & @kitdesai

https://github.com/CodeMonk/PyAPNs2/tree/feature/port-to-httpx is @CodeMonk's port.

https://github.com/chrigu/PyAPNs2/tree/feature/httpx is another port by @chrigu

Worth noting that several libraries using apns2 have switched to using https://github.com/Fatal1ty/aioapns , which only depends on h2,pyopenssl&pyjwt rather than httpx which has a large dependency tree (see https://www.wheelodex.org/projects/httpx/ ).

jayvdb avatar Oct 19 '21 21:10 jayvdb

ping everyone , has any of these ports progressed at all?

jayvdb avatar Jan 09 '22 03:01 jayvdb

@jayvdb I just made the parts working that I needed for my project and my port won't be developed any further.

chrigu avatar Jan 09 '22 15:01 chrigu

And we replaced PyAPNs2 with aioapns, which required a bit of extra work to make sure threads are properly initialised but works really well with python >= 3.8

erwan-lemonnier avatar Jan 09 '22 21:01 erwan-lemonnier

Any chance of a release?

daveisfera avatar May 09 '22 16:05 daveisfera

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 08 '22 00:11 github-actions[bot]

There is some progress at https://github.com/Pr0Ger/PyAPNs2/pull/149

jayvdb avatar Nov 08 '22 00:11 jayvdb

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar May 11 '23 00:05 github-actions[bot]

This is still an issue

daveisfera avatar May 11 '23 03:05 daveisfera

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 11 '23 00:11 github-actions[bot]

This is still an issue

daveisfera avatar Nov 11 '23 17:11 daveisfera