vscode-powershell
vscode-powershell copied to clipboard
Bump to Node 22.15.1 and removes node-fetch
Fixes #5213
PR Summary
Bumps to Node 22.15.1 and removes node-fetch. Requires VSCode v1.101 or higher for future extension releases.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.
- [x] PR has a meaningful title
- [x] Summarized changes
- [x] PR has tests
- [x] This PR is ready to merge and is not work in progress
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready
- If the PR is work in progress, please add the prefix
@andyleejordan eslint got real mad at me for unchanged stuff, do we want to fix these or add a rules exclusion?
Ah a few things missing. This is complicated enough that I documented it here: https://github.com/PowerShell/vscode-powershell/blob/main/docs/development.md#tracking-upstream-dependencies
Mostly need to be sure to cross reference everything (which I think you did) and update both pipelines.
I have generally gone ahead and fixed new ESLint errors rather than suppress them when updating Node.js.
@andyleejordan I rebased this commit and cleaned it up a bit, unless I was missing something in your comments it should be OK now and match your notes.
There is no TSConfig update needed, and now it mostly just needs the vscode and node packages bumped in the private packages and should be good.
Ran update again and updated the package feed. I now have to use artifacts-npm-credprovider to auth against, and that tool is so broken seriously it only worked once I deleted every line but registry=... from .npmrc. Even comments broke it
@andyleejordan thank you!