vscode-powershell icon indicating copy to clipboard operation
vscode-powershell copied to clipboard

Review: 1.90.0 VSCode Native PowerShell IntelliSense Issues

Open JustinGrote opened this issue 1 year ago • 5 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [X] I have searched all issues to ensure it has not already been reported.

Summary

1.90 has some new preview PowerShell Intellisense https://code.visualstudio.com/updates/v1_90#_vs-codenative-intellisense-for-powershell

image

Should probably make sure there aren't any conflicts with this extension. I'm sure they tested, but still.

This is an overall tracker to open issues over in the VSCode repository if they don't get fixed or aren't being tracked otherwise, so we will need to mitigate or provide warnings in our extension if we detect it is enabled.

VSCode Tracking Issue

Observed Issues

  • [ ] Font Settings dont work
  • [ ] Hijacks Tab and Ctrl-Enter PSReadline, doesn't complete in a manner expected by PS
  • [ ] Repeated Entries observed (e.g. same function listed 3 times)
  • [ ] Not all completions showing. For instance parameter completion above only shows P parameters even tho I didn't specify that far in the completion.

JustinGrote avatar Jun 06 '24 00:06 JustinGrote

@andyleejordan are you in any coordination with the vscode team on this?

JustinGrote avatar Jun 06 '24 00:06 JustinGrote

@JustinGrote we sync up every month. I don't directly test the pwsh extension and I'm not aware of any conflicts. The 3 latter issues you mention seem like they should be tracked in new VS Code issues.

Hijacks Tab and Ctrl-Enter PSReadline, doesn't complete in a manner expected by PS

If you mean it's hijacked when the suggest widget is visible, this is by design. Everything except for ctrl+space should work the same as before when it's hidden (via escape, configure settings to change when it's shown).

Tyriar avatar Jun 07 '24 14:06 Tyriar

Sounds great! This was mostly to verify as a sanity check, and as mentioned, I'll open issues as-found once I have more time to evaluate.

JustinGrote avatar Jun 07 '24 15:06 JustinGrote

Lots of improvements coming in the next release, summary here: https://github.com/microsoft/vscode/issues/223130

Tyriar avatar Jul 23 '24 18:07 Tyriar

Thanks @Tyriar looks great, Andy's excited to go test.

SydneyhSmith avatar Jul 25 '24 17:07 SydneyhSmith