vscode-powershell icon indicating copy to clipboard operation
vscode-powershell copied to clipboard

Double prompt when closing powershell extension terminal

Open Tyriar opened this issue 3 years ago • 2 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [ ] I have searched all open and closed issues to ensure it has not already been reported.
  • [ ] I have read the troubleshooting guide.
  • [ ] I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • [ ] I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • [ ] If this is a security issue, I have read the security issue reporting guidance.

Summary

I closed the terminal and got 2 notifications

PowerShell Version

N/A

Visual Studio Code Version

Version: 1.71.0-insider (user setup)
Commit: 28f604dec81b609dd7e69362585f7a99d4c48f88
Date: 2022-08-19T05:17:14.894Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22000
Sandboxed: Yes

Extension Version

[email protected]

Steps to Reproduce

Open a ps1 file, close the terminal

Visuals

image

Logs

No response

Tyriar avatar Aug 19 '22 14:08 Tyriar

Known issue, I've already filed a request upstream for us to improve this together: https://github.com/microsoft/vscode-languageserver-node/issues/1057

andyleejordan avatar Aug 19 '22 17:08 andyleejordan

FWIW I'm also considering turning showOnStartup false by default, so that the terminal pane isn't opened when the extension activates, and then setting this to CloseAction.Restart automatically, which especially with the startInBackground option for those that never want to see the terminal could make the extension far less noisy, but also always on and working. @SeeminglyScience thoughts?

andyleejordan avatar Aug 26 '22 16:08 andyleejordan