vscode-powershell icon indicating copy to clipboard operation
vscode-powershell copied to clipboard

Feature Request: Integrate Inline Completions API with Predictive Intellisense

Open JustinGrote opened this issue 3 years ago • 3 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [X] I have searched all issues to ensure it has not already been reported.

Summary

The inline completions API is finalized, perhaps we want to offer an option to call the psreadline completion operator for each new line? This could be difficult to performance optimize https://code.visualstudio.com/updates/v1_68#_inline-completions-finalization

Proposed Design

No response

JustinGrote avatar Jun 10 '22 18:06 JustinGrote

I'm unsure if that makes sense for general completions tbh

It does however seem like a good way to hook up predictions if we ever find a compelling scenario.

SeeminglyScience avatar Jun 10 '22 18:06 SeeminglyScience

@StevenBucher98 as I think he has looked into this a bit

SydneyhSmith avatar Jun 13 '22 17:06 SydneyhSmith

Since this is in the editor experience, ideally predictions would be contextually aware of things like variable names and how they might populate parameter set. This wouldn't work with just calling into the PSReadLine Predictors.

That being said it would actually be interesting maybe calling into particular predictors that may not need to utilize context awareness, specifically the Completor Predictor comes to mind. cc @daxian-dbw @theJasonHelmick

StevenBucher98 avatar Jun 13 '22 18:06 StevenBucher98