openssh-portable icon indicating copy to clipboard operation
openssh-portable copied to clipboard

Published 20 hours ago • verified publisher icon PowerShell

Replace backspace code on client side from 0x7F by 0x08

Open kor44 opened this issue 1 year ago • 7 comments

PR Summary

Replace backspace code from Control-? to Control-H

PR Context

Some proprietary SSH servers use Control-H (ASCII code 8) as default code for backpace if ssh client does not provide ERASE option. OpenSSH does not support to set this option as Putty. I have modified input processing on client side to replace Control-? (ASCII code 127) by Control-H (ASCII code 8). There is pull request Handle backspace (Control+?) in no-pty session which add support processing Control-? on server side of OpenSSH

kor44 avatar Jan 24 '24 20:01 kor44

/AzurePipelines run

tgauth avatar Jan 29 '24 22:01 tgauth

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 29 '24 22:01 azure-pipelines[bot]

I have synced my branch but it's very strange that not used latest from the beginning.

I made tests with different OpenSSH server versions (OpenSSH_8.4, OpenSSH_8.0 linux) type "this is a test" and backspace works as expected (delete single symbol) even when set console locate as UTF-8

kor44 avatar Feb 05 '24 22:02 kor44

@kor44, ah ok - I tested with the latest Win32-OpenSSH (version 9.5) as the server & client (with the proposed change). My primary concern is the behavior on the latest versions for Windows/Linux.

tgauth avatar Feb 12 '24 23:02 tgauth

Should I make some actions to merge this pull request?

kor44 avatar Feb 23 '24 19:02 kor44

Should I make some actions to merge this pull request?

No, the PR needs to be approved before it can be merged. I'm still concerned about the behavior change with the latest OpenSSH server versions (9.5 for Windows, and 9.7 for Linux (as of today))

I made tests with different OpenSSH server versions (OpenSSH_8.4, OpenSSH_8.0 linux)

Please test with the latest OpenSSH server versions mentioned above.

tgauth avatar Mar 11 '24 15:03 tgauth

Should I make some actions to merge this pull request?

No, the PR needs to be approved before it can be merged. I'm still concerned about the behavior change with the latest OpenSSH server versions (9.5 for Windows, and 9.7 for Linux (as of today))

I made tests with different OpenSSH server versions (OpenSSH_8.4, OpenSSH_8.0 linux)

Please test with the latest OpenSSH server versions mentioned above.

I have only access to Linux (OpenSSH_9.6p1, OpenSSL 3.2.1 30 Jan 2024)

kor44 avatar Mar 23 '24 21:03 kor44