Win32-OpenSSH icon indicating copy to clipboard operation
Win32-OpenSSH copied to clipboard

ssh-agent present in .gitignore

Open LexaPrime opened this issue 1 year ago • 1 comments
trafficstars

Prerequisites

  • [X] Write a descriptive title.
  • [X] Make sure you are able to repro it on the latest version
  • [X] Search the existing issues.

Steps to reproduce

.gitignore contains ssh-agent in line 28, which ignores contrib/win32/win32compat/ssh-agent/. That folder is included in the repository, and necessary to build ssh-agent.vcxproj. Was this intended?

Expected behavior

All projects are built correctly.

Actual behavior

When pushing the repository to a different remote, `contrib/win32/win32compat/ssh-agent/` is ignored. Building the solution after cloning from such remote results in several C1083 errors, for example:
`C1083 Cannot open source file: '(...)\contrib\win32\win32compat\ssh-agent\agent-main.c': No such file or directory`

Error details

No response

Environment data

N/A

Version

latestw_all

Visuals

No response

LexaPrime avatar Jul 25 '24 09:07 LexaPrime

Line 28 in the .gitignore is from upstream - it is to prevent pushing the built ssh-agent binary to the repo. It should not prevent cloning agent-main.c from this repo - https://github.com/PowerShell/openssh-portable/blob/latestw_all/contrib/win32/win32compat/ssh-agent/agent-main.c

If you still have issues building the project, please provide more details about the scenario.

tgauth avatar Jul 29 '24 18:07 tgauth