PowerShellGetv2 icon indicating copy to clipboard operation
PowerShellGetv2 copied to clipboard

Cert checking is overly restrictive

Open kilasuit opened this issue 4 years ago • 2 comments

In some of our internal modules we are using Lability https://github.com/VirtualEngine/Lability which recently changed a few minor details in their code signing cert which has caused PowerShellGet to throw an error as per https://github.com/VirtualEngine/Lability/issues/382

This effects v2.2.3 of PowerShellGet

Whilst the scenario to change locations isn't likely very frequent, it is still valid and should not throw an error like this and allow without the need of SkipPublisherCheck parameter

image

Note that in the above only the C fields in the cert have changed - the O hasn't and that's really what we should be matching on within checks in PowerShellGet

kilasuit avatar Feb 04 '20 13:02 kilasuit

Having the same problem even with PSGet v 2.2.5, did you ever manage to get a fix for this? Passing the -SkipPublisherCheck param isnt an option as I'm relying on RequireModules in the psd to install the module.

image

Shane-OH avatar Nov 12 '20 12:11 Shane-OH

Yeah... as @Shane-OH reported this is not allowing PowershellGet to install AWSPowerShell.NetCore 4.1.2.0 on a machine which already has AWSPowershell.NetCore 4.0.5.0 already installed because the root certification authorities differ: AWSPowershell.NetCore 4.0.5.0's root certification authority is VeriSign Universal Root Certification Authority while version 4.1.2.0 has Amazon Web Services, Inc. .

kduvzc avatar Nov 25 '20 11:11 kduvzc