PSDscResources icon indicating copy to clipboard operation
PSDscResources copied to clipboard

Added support for Exclusive flag parameter which ensures the a value is the EXCLUSIVE value in a given key.

Open bobbytreed opened this issue 8 years ago • 5 comments

Other resources (like UserRightsAssignment) perform this operation with the FORCE parameter. Here the FORCE parameter is used to remove Keys that have subkeys. Other names can be considered, but a flag is the most logical option. The impact is low for this change as current implementations would not at all be affected.

Fixes #63


This change is Reviewable

bobbytreed avatar May 30 '17 12:05 bobbytreed

Codecov Report

Merging #64 into dev will decrease coverage by <1%. The diff coverage is 65%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #64   +/-   ##
===================================
- Coverage    83%    83%   -1%     
===================================
  Files        19     19           
  Lines      2751   2780   +29     
  Branches      4      5    +1     
===================================
+ Hits       2294   2313   +19     
- Misses      453    462    +9     
- Partials      4      5    +1

codecov-io avatar May 30 '17 13:05 codecov-io

Discussing some design patterns with Bobby offline.

zjalexander avatar Jun 15 '17 17:06 zjalexander

Are there any updates on this PR or has it been abandoned for the time being?

mbreakey3 avatar Oct 30 '17 18:10 mbreakey3

We were discussing design implications with Mark. Since Mark has moved on, let me loop @mgreenegit in.

zjalexander avatar Oct 31 '17 00:10 zjalexander

@mgreenegit Can you glance at this PR so we can remove the 'on hold' label, and then we can review it.

@bobbytreed Are you still able to work on this issue if we can remove the 'on hold' label?

johlju avatar Apr 30 '18 12:04 johlju