DscResources icon indicating copy to clipboard operation
DscResources copied to clipboard

Link GroupPolicyDsc resource

Open corydwood opened this issue 5 years ago • 5 comments

Closes #101

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • [ ] This PR changes documentation
  • [ ] This PR changes DscResource.Template
    • [ ] Updated documentation as necessary in the TEMPLATE_README.md.
    • [ ] An descriptive entry has been added to the change log in the TEMPLATE_README.md.
  • [ ] This PR changes Tests.Template
    • [ ] The template version number has been increased appropriately.
    • [ ] An descriptive entry has been added to the CHANGELOG.md under the Tests.Template folder.

This change is Reviewable

New resource module submission

Name: GroupPolicyDsc

Repository URL: https://github.com/corydwood/GroupPolicyDsc

Short description: This module contains the GPInheritance, GPOImport, and GPOLink DSC resources.

New resource module submission task list

This task list can be filled in after the issue has been submitted.

  • [] Pass the Quality Governance
  • [x] Pull request is sent in (see next section).
  • [x] The new module submission in ready for community review.

Steps that pull request should include

  • [x] Added submodule using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>.
  • [x] Updated resource module list in Maintainers.md.

Community acceptance

Community reviewers: Please submit a comment on the issue for each box that are checked so the community know who accepted the item.

The new resource module:

  • [ ] is licensed under MIT.
  • [ ] has the correct project structure.
  • [ ] has a dev and master branch, and dev should default branch.
  • [ ] is using DSC Resource Kit test templates.
  • [ ] is connected to Codecov or similar.
  • [ ] has established a code of conduct in ether a CODE_OF_CONDUCT.md or a 'Code of conduct' section in the README.md.
  • [ ] has either a CONTRIBUTING.md file or a 'Contributing' section in the README.md file.
  • [ ] has included the metadata tag 'DSCResource' in the module manifest.
  • [ ] is sufficiently documented.
  • [ ] has an established CI process for each push to the repository.
  • [ ] is sufficiently tested.
  • [ ] Follows the guidelines set out for a High Quality Resource Module.

Submission acceptance

The community accepts, at a community call, that a resource module follows the guidelines set out for a High Quality Resource Module.

  • [ ] The resource module was accepted for submission in a community call.

corydwood avatar Jan 15 '19 21:01 corydwood

I of course meant with the review comment if your repo can change to the appveyor.yml template 😄

johlju avatar Feb 03 '19 16:02 johlju

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

stale[bot] avatar Feb 17 '19 16:02 stale[bot]

Disabled the Stale bot and changed the labels. Also talked to Cory who'll get back to this as soon as he can.

gaelcolas avatar Mar 13 '19 13:03 gaelcolas

I have permission on the repository, and I will see if I can get this resource in good shape for next Community call where we'll be able to reconsider this.

gaelcolas avatar Jun 25 '19 13:06 gaelcolas

As announced during the last community call, we'd love to have this as part of dsccommunity. @corydwood gave me permissions to the repo and I'll try to get this re-homed when we transfer to the new GitHub organisation in a few weeks.

gaelcolas avatar Aug 02 '19 14:08 gaelcolas