DSC icon indicating copy to clipboard operation
DSC copied to clipboard

Enable rustfmt in repo and fix current formatting

Open SteveL-MSFT opened this issue 2 months ago • 1 comments

PR Summary

Add rustfmt under -clippy. There is a new -FmtFix switch for build.ps1 to automatically make formatting fixes, otherwise, CI will fail if rustfmt checks fail.

Used a slightly modified version of the proposed rustfmt.toml, however, many of the options are only available in the nightly channel and not the stable one. I decided to keep them in the toml but not to use the nightly channel for now (due to being unstable by definition).

All the code changes are just formatting changes. However, due to the formatting changes, some functions became too long so added #[allow(clippy::too_many_lines)] to some functions for now.

Making this a draft for now, the features we need in rustfmt are only available in the nightly toolchain and we don't want to take a dependency on that. Will revisit when the nightly features show up in stable.

PR Context

Fix https://github.com/PowerShell/DSC/issues/1155

SteveL-MSFT avatar Oct 07 '25 21:10 SteveL-MSFT

It also seems within the Rust community that rustfmt isn't being actively maintained

SteveL-MSFT avatar Oct 08 '25 17:10 SteveL-MSFT