power-grid-model
power-grid-model copied to clipboard
Install all dependencies in check-code-quality.yml
TODO: add step before all code quality checks to pip install -e .[dev]
because
numpy
was not installed in this pipeline, the pipeline did not check mypy on any lines containingnumpy
arrays (which is quite a lot). as a result, we now did not catch stuff on mypy that we should have caught.installing
numpy
into this pipeline enabled checking mypy on lines containing numpy arrays.now, if, in the future, we also have other dependencies that we want to use in our own mypy checks, we would also have to add those to this pipeline.
However, if we have a step before running any of the code quality checks that does
pip install -e .[dev]
, then all those dev dependencies are already installed automatically, so we don't need to explicitly add them here.
Originally posted by @mgovers in https://github.com/PowerGridModel/power-grid-model/pull/753#discussion_r1782350978