power-grid-model icon indicating copy to clipboard operation
power-grid-model copied to clipboard

feature/update main model for automatic tap changer

Open Jerry-Jinfeng-Guo opened this issue 9 months ago • 1 comments

  • [ ] Update main_core/output → function skeletons are already in place (main_core.hpp and output.hpp). User will need to be able to extract certain data (tap positions, etc.).
  • [ ] Attribute input should be checked (should have been in place)
  • [ ] attr output (optimizer >all the way back> output structure) needs to be done
  • [x] add check to ensure that there can at most be one regulator for each transformer
  • [ ] include unit tests for the input/update/output functions of automatic tap changer.

Jerry-Jinfeng-Guo avatar May 15 '24 12:05 Jerry-Jinfeng-Guo

At the moment the tap_position_optimizer still writes everything to a SolverOutput. The addition of MathOutput to include both SolverOutput and OptimizerOutput seems ignored. @mgovers Could the automatic tap changer adapt before I continue?

Jerry-Jinfeng-Guo avatar May 16 '24 14:05 Jerry-Jinfeng-Guo

At the moment the tap_position_optimizer still writes everything to a SolverOutput. The addition of MathOutput to include both SolverOutput and OptimizerOutput seems ignored. @mgovers Could the automatic tap changer adapt before I continue?

Yes the optimizer needs to output a MathSolver that includes both the SolverOutput and the OptimizerOutput if that is waht you mean

mgovers avatar May 16 '24 16:05 mgovers