power-grid-model
power-grid-model copied to clipboard
[Feature] Automatic Tap Changer C API
- Add automatic tap position as experimental feature to C API
- Add
PGM_TapChangingStrategy
enum - Add
PGM_set_tap_changing_strategy
option setter
@mgovers I have reviewed and approved the PR. I am not sure if this should now be merged before main_model
is ready.
@mgovers I have reviewed and approved the PR. I am not sure if this should now be merged before
main_model
is ready.
i don't think it matters. with the current implementation in this PR, you do get the optimal state - just not the optimal tap positions. I would consider it a missing feature
rather than a critical feature
.
After this PR is merged, the validation tests can already be created and even run - provided we do not check for the tap positions. We can also start the Python API creation.
Since we do not give any guarantees for experimental features, I think having missing features
is OK.
If experimental_feature
does not carry the load of feature_under_construction
, then maybe we should add that flag as well. Maybe that's something up for discussion for our next big thing
Quality Gate passed
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code