pdns icon indicating copy to clipboard operation
pdns copied to clipboard

our Makefiles are gmake-specific

Open Habbie opened this issue 8 years ago • 3 comments

  • Program: Authoritative, Recursor, dnsdist
  • Issue type: Feature request

Short description

Our Makefiles fail on BSD-make - in some places they error out, but worse, in some other places they silently do the wrong thing.

Expected behaviour

Successful compile.

Actual behaviour

Problems.

Other information

This ticket is light on details, for which I apologise, I just recalled this problem without running into it specifically right now.

I know for dnsdist, this pops up specifically when you build with protobuf.

Suggested fixes:

  • remove GNUisms (hard)
  • abort early when not running under gmake (easier) - wonder if we can tell autotools to write GNUmakefile instead of Makefile?

Habbie avatar Feb 05 '17 19:02 Habbie

gmake requirement is in the README though :)

zeha avatar Feb 05 '17 19:02 zeha

@zeha nobody reads it. I don't. Even my own OS-specific notes I will only look for if things fail ;)

Habbie avatar Feb 05 '17 19:02 Habbie

remove GNUisms (hard)

I think the only GNU-isms we use is $< (but it makes for an easier read of the makefile.am)

abort early when not running under gmake (easier) -

https://www.gnu.org/software/autoconf-archive/ax_check_gnu_make.html

wonder if we can tell autotools to write GNUmakefile instead of Makefile?

A quick look at the info pages says 'no'

pieterlexis avatar Feb 06 '17 09:02 pieterlexis