pdns icon indicating copy to clipboard operation
pdns copied to clipboard

tarball missing (js) sources

Open zeha opened this issue 10 years ago • 14 comments

Auth (in order of importance):

  • [x] ext/mbedtls/gpl-2.0.txt missing
  • [x] pdns/dnsdistdist is uselessly included (and has .js files with addtl. licenses, see below)
  • [x] missing source files for docs/markdown/theme/js/bootstrap-3.0.3.min.js docs/markdown/theme/js/prettify-1.0.min.js
  • [x] pdns/dnsdist* is included but not used (not important)
  • [x] pdns/(pdns_recursor,syncres,ws-recursor,...).cc is included but not used (not important)
  • [x] build-scripts/semistaticg++ is included but not used
  • [x] missing source files for pdns/dnsdistdist/html/js/d3.v3.js pdns/dnsdistdist/html/js/jquery-1.8.3.min.js pdns/dnsdistdist/html/js/moment.min.js pdns/dnsdistdist/html/js/rickshaw.min.js pdns/dnsdistdist/html/js/underscore-min.js

Recursor:

  • [x] includes unusable build-scripts file(!) - will be fixed by #3075 i think
  • [x] missing source files for html/js/*.js

dnsdist:

  • [ ] missing source files for html/js/*.js
  • [x] missing ext/incbin/UNLICENSE
  • [x] missing ext/mbedtls/gpl-2.0.txt
  • [x] missing LICENSE
  • [x] missing source for dnsdist.1
  • [x] build-aux/gen-version missing (breaks autoreconf)

zeha avatar Dec 25 '15 17:12 zeha

missing source files for

  • docs/markdown/theme/js/bootstrap-3.0.3.min.js
  • docs/markdown/theme/js/prettify-1.0.min.js

These were (are) grabbed as-is from the mkdocs themes. I could add a small readme/license file.

pieterlexis avatar Dec 28 '15 19:12 pieterlexis

@pieterlexis please do, also debian needs the unminified sources, too.

zeha avatar Jan 02 '16 18:01 zeha

mkdocs doesn't ship the un-minified sources :disappointed:

pieterlexis avatar Jan 03 '16 12:01 pieterlexis

missing source files for

  • docs/markdown/theme/js/bootstrap-3.0.3.min.js
  • docs/markdown/theme/js/prettify-1.0.min.js

These were (are) grabbed as-is from the mkdocs themes. I could add a small readme/license file.

Just looked at docs/markdown/theme/css/bootstrap-custom.min.css, and I'm thinking shipping source for that is either hopeless or a very enterprisey task. Would you be ok with rearranging the prebuilt sources into a vendor/ folder? That way I can just exclude them when importing your tarballs and symlink in the files from the libjs-bootstrap package (OTOH this means following major version upgrades in a timely manner, I think).

zeha avatar Jan 15 '16 14:01 zeha

Updated the list, only the javascript issues remain.

pieterlexis avatar Feb 17 '16 10:02 pieterlexis

The checklist says this is done for the recursor, but pdns-recursor-4.0.0-alpha2.tar.bz2 still contains minified javascript files.

rubenk avatar Mar 13 '16 09:03 rubenk

IANAL, but can we mention something somewhere about the license of those files?

rubenk avatar Mar 13 '16 09:03 rubenk

The jquery in recursordistdist is 1.8.3, which is unmaintained, and has some vulnerabilities.

rubenk avatar Mar 13 '16 10:03 rubenk

recursor tarball now also misses sources for html/js/*.js

zeha avatar May 12 '16 20:05 zeha

if you want to make my life easier, please supply sources along the minified files, so f.e. have moment.js next to moment.min.js :)

zeha avatar May 12 '16 20:05 zeha

Working on the mkdocs theme here: https://github.com/zeha/pdns/tree/doc-js

zeha avatar Jun 07 '16 21:06 zeha

As discussed Yesterday over lunch, removing the mkdocs theme from the tarball might be the easiest option.

zeha avatar Jun 10 '16 10:06 zeha

@zeha I think the recursor is fixed with #3981?

pieterlexis avatar Jul 05 '16 22:07 pieterlexis

I think so.

zeha avatar Jul 05 '16 22:07 zeha