PowerDNS
changelog-from-pr: Sort PRs based on their ID
Short description
Checklist
I have:
- [x] read the CONTRIBUTING.md document
- [x] read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
- [ ] compiled this code
- [x] tested this code
- [ ] included documentation (including possible behaviour changes)
- [ ] documented the code
- [ ] added or modified regression test(s)
- [ ] added or modified unit test(s)
What's the point of this? Shouldn't the chronological order of their merges be preferred?
Using the ID made it very easy to get some ordering based on the creation date of the PR, while ordering on the merge date would require more work. I don't really care, to be honest.
Pull Request Test Coverage Report for Build 19129824260
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 38 unchanged lines in 8 files lost coverage.
- Overall coverage increased (+0.03%) to 73.003%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/iputils.hh | 1 | 77.2% |
| modules/godbcbackend/sodbc.cc | 2 | 70.08% |
| pdns/rcpgenerator.cc | 2 | 90.95% |
| pdns/recursordist/rec-main.cc | 2 | 64.78% |
| pdns/packethandler.cc | 3 | 72.37% |
| pdns/recursordist/test-syncres_cc2.cc | 3 | 89.18% |
| pdns/recursordist/rec-tcpout.cc | 6 | 73.23% |
| pdns/recursordist/rec-system-resolve.cc | 19 | 45.92% |
| <!-- | Total: | 38 |
| Totals | |
|---|---|
| Change from base Build 19128763336: | 0.03% |
| Covered Lines: | 127390 |
| Relevant Lines: | 163817 |
💛 - Coveralls
I didn't even realise we had this, I still use build-scripts/git-to-changelog-merges and then massage it into .rst form :scream:
As for ordering, I think without this PR, we get merge order automatically? And then things also get grouped by tags. I think PR numeric order (as this PR does) would look slightly cleaner in any case.
