PowerDNS
dnsdist and rec: Prevent generating release tarballs via autotools
Short description
WIP to fix https://github.com/PowerDNS/pdns/issues/16164
Checklist
I have:
- [ ] read the CONTRIBUTING.md document
- [ ] read and accepted the Developer Certificate of Origin document, including the AI policy, and added a "Signed-off-by" to my commits
- [ ] compiled this code
- [ ] tested this code
- [ ] included documentation (including possible behaviour changes)
- [ ] documented the code
- [ ] added or modified regression test(s)
- [ ] added or modified unit test(s)
- [ ] checked that this code was merged to master
Pull Request Test Coverage Report for Build 18380824023
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 11690 unchanged lines in 110 files lost coverage.
- Overall coverage increased (+0.1%) to 64.196%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/signingpipe.cc | 1 | 87.94% |
| ext/yahttp/yahttp/utility.hpp | 2 | 36.04% |
| pdns/burtle.hh | 2 | 98.19% |
| pdns/channel.hh | 2 | 57.79% |
| pdns/dns.cc | 2 | 88.29% |
| pdns/dnsdistdist/dnsdist-dnsquestion.cc | 2 | 70.59% |
| pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc | 2 | 48.0% |
| pdns/dnsdistdist/dnsdist-lua.hh | 2 | 46.69% |
| pdns/epollmplexer.cc | 2 | 85.71% |
| pdns/libssl.hh | 2 | 0.0% |
| <!-- | Total: | 11690 |
| Totals | |
|---|---|
| Change from base Build 18359303538: | 0.1% |
| Covered Lines: | 130024 |
| Relevant Lines: | 167883 |
💛 - Coveralls
I won't approve as I am (co-) author. But I tested locally and successfully.
I still see some places where make dist is mentioned:
build-scripts/dist-dnsdist
15:make dist
build-scripts/dist-recursor
15:make dist
DEVELOPMENT.md
27:make distclean # Ensure we rebuild all files so that bear can pick them up.
41:make distclean # Ensure we rebuild all files so that bear can pick them up.
builder-support/dockerfiles/Dockerfile.authoritative
23: make dist
tasks.py
956: c.run('make distdir')
I think this should be cleaned up/verified.
I still see some places where
make distis mentioned:build-scripts/dist-dnsdist 15:make dist
build-scripts/dist-recursor 15:make dist
No idea if these two are used, I'd say: zap and see what breaks
DEVELOPMENT.md 27:make distclean # Ensure we rebuild all files so that bear can pick them up. 41:make distclean # Ensure we rebuild all files so that bear can pick them up.
make distclean still works.
builder-support/dockerfiles/Dockerfile.authoritative 23: make dist
Auth did not convert yet.
tasks.py 956: c.run('make distdir')
Auth did not convert yet.
I think this should be cleaned up/verified.
I still see some places where
make distis mentioned: build-scripts/dist-dnsdist 15:make dist build-scripts/dist-recursor 15:make distNo idea if these two are used, I'd say: zap and see what breaks
Done.
You have triggered a rate limit. Please wait a few minutes before you try again; in some cases this may take up to an hour.
I have not been really happy with coveralls lately, but I still find getting the code coverage reports useful. I wonder if it would make sense to only generate it when a commit is pushed to master.
No idea if these two are used, I'd say: zap and see what breaks
that then is the final nail in buildbot's coffin. Which is fine :)
Do we still have anything that lives only on buildbot?
the master- repos on repo.powerdns.com, which will hopefully be Pulp-ified soon