pdns icon indicating copy to clipboard operation
pdns copied to clipboard

rec validate: use rfc1982 math for RRSIG timestamps

Open Habbie opened this issue 6 months ago • 2 comments

Short description

needs tests. EDE reporting in checkSignatureInceptionAndExpiry also needs adjusting.

Checklist

I have:

  • [x] read the CONTRIBUTING.md document
  • [x] compiled this code
  • [x] tested this code
  • [ ] included documentation (including possible behaviour changes)
  • [ ] documented the code
  • [ ] added or modified regression test(s)
  • [ ] added or modified unit test(s)
  • [ ] checked that this code was merged to master

Habbie avatar Jun 09 '25 13:06 Habbie

I'm pretty sure this is going to need a release note 😉

jsoref avatar Jun 09 '25 14:06 jsoref

Pull Request Test Coverage Report for Build 15630229576

Details

  • 72 of 72 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rrsig-times-1982 at 65.509%

Totals Coverage Status
Change from base Build 15630185130: 65.5%
Covered Lines: 125666
Relevant Lines: 163388

💛 - Coveralls

coveralls avatar Jun 09 '25 14:06 coveralls