pdns icon indicating copy to clipboard operation
pdns copied to clipboard

Upgrade check-spelling to v0.0.25

Open jsoref opened this issue 7 months ago • 1 comments

Short description

Upgrade check-spelling to v0.0.25

[!IMPORTANT] SARIF reporting now relies on github-advanced-security 🤖 (you need to use github rulesets to enforce) see https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset

[!NOTE]
Anyone using a disconnected private clone of this repository in GitHub who isn't paying for GitHub Advanced Security will want to set the actions environment variable DO_NOT_USE_SARIF_REPORTING to 1 in order to suppress a warning from check-spelling. Even without this setting, it will work, specifically without sarif reporting, but without this setting, check-spelling will complain that your repository is misconfigured.

There are various other improvements, including some formatting things, and items in the details table, but mostly things should just work.

Dictionary downloading has theoretically improved and should handle errors from servers better, however github seems to be sending errors more often, so I'll probably need to suggest some alternate approaches to it. If you hit errors w/ dictionaries, a rerun should on average work, but please let me know that you've hit it as that'll lead to me looking into reworking their handling sooner. -- I might switch to posting dictionaries as "release artifacts" instead of just retrieving them from github's raw endpoint -- currently I'm just thinking about the problem as opposed to rushing to a solution.

Checklist

I have:

  • [x] read the CONTRIBUTING.md document
  • [x] compiled this code
  • [x] tested this code
  • [ ] included documentation (including possible behaviour changes)
  • [ ] documented the code
  • [ ] added or modified regression test(s)
  • [ ] added or modified unit test(s)
  • [ ] checked that this code was merged to master

jsoref avatar May 20 '25 18:05 jsoref

Recursor docs related changes look good

omoerbeek avatar May 23 '25 14:05 omoerbeek

Pull Request Test Coverage Report for Build 16000521255

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.007%) to 65.601%

Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 1 64.41%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.8%
pdns/dnsdistdist/dnsdist-tcp.cc 1 77.49%
pdns/recursordist/recursor_cache.cc 1 84.03%
pdns/recursordist/aggressive_nsec.cc 2 65.8%
pdns/sstuff.hh 2 57.14%
pdns/iputils.cc 3 56.95%
pdns/stubresolver.cc 3 77.02%
pdns/dnsdistdist/dnsdist-carbon.cc 9 62.07%
pdns/recursordist/syncres.cc 12 80.29%
<!-- Total: 50
Totals Coverage Status
Change from base Build 15998617075: -0.007%
Covered Lines: 126929
Relevant Lines: 164831

💛 - Coveralls

coveralls avatar Jul 01 '25 13:07 coveralls