pdns
pdns copied to clipboard
Support new SVCB parameters: ohttp, dohpath, tls-supported-groups
Short description
#15479
TODO:
- [ ] write more unit tests
- [ ] find a working implementation to compare against, dig 9.20.8 and drill 1.8.4 do not understand the new types yet
- [ ] fix the (preexisting) clang-tidy issues in test-svc_records_cc.cc
- [ ] remove quotes around dohpath data
Checklist
I have:
- [x] read the CONTRIBUTING.md document
- [x] compiled this code
- [x] tested this code
- [ ] included documentation (including possible behaviour changes)
- [ ] documented the code
- [x] added or modified regression test(s)
- [x] added or modified unit test(s)
Any chance to get this into 5.0 release? In our tests this PR worked.
Pull Request Test Coverage Report for Build 18135500305
Details
- 330 of 333 (99.1%) changed or added relevant lines in 8 files are covered.
- 34 unchanged lines in 6 files lost coverage.
- Overall coverage increased (+0.07%) to 66.164%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pdns/dnsparser.cc | 17 | 20 | 85.0% |
| <!-- | Total: | 330 | 333 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/recursordist/aggressive_nsec.cc | 2 | 66.39% |
| modules/godbcbackend/sodbc.cc | 4 | 70.08% |
| pdns/dnsdistdist/dnsdist-tcp.cc | 4 | 77.33% |
| pdns/recursordist/lwres.cc | 6 | 66.3% |
| ext/json11/json11.cpp | 7 | 62.65% |
| pdns/tcpiohandler.cc | 11 | 69.64% |
| <!-- | Total: | 34 |
| Totals | |
|---|---|
| Change from base Build 18102068545: | 0.07% |
| Covered Lines: | 129614 |
| Relevant Lines: | 167169 |