pdns
pdns copied to clipboard
PowerDNS
dnsdist setTicketsKeyAddedHook(): adjust type of the key to fix potential truncate
The key received on the lua side might be truncated if it contains the null char. By changing the type of the prototype, the lua wrapper uses the key.size() method to evaluate the actual size.
Short description
Checklist
I have:
- [x] read the CONTRIBUTING.md document
- [x] compiled this code
- [x] tested this code
- [ ] included documentation (including possible behaviour changes)
- [ ] documented the code
- [ ] added or modified regression test(s)
- [ ] added or modified unit test(s)
Pull Request Test Coverage Report for Build 11308145580
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- 117 unchanged lines in 18 files lost coverage.
- Overall coverage increased (+0.1%) to 64.702%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/packethandler.cc | 1 | 72.68% |
| modules/gpgsqlbackend/gpgsqlbackend.cc | 1 | 88.62% |
| pdns/pollmplexer.cc | 1 | 83.66% |
| pdns/recursordist/recursor_cache.cc | 1 | 86.38% |
| pdns/backends/gsql/gsqlbackend.hh | 2 | 97.71% |
| pdns/ws-auth.cc | 2 | 80.84% |
| pdns/recursordist/test-syncres_cc2.cc | 3 | 89.03% |
| pdns/tsigverifier.cc | 3 | 77.22% |
| pdns/recursordist/recpacketcache.hh | 3 | 91.04% |
| pdns/iputils.hh | 3 | 78.29% |
| <!-- | Total: | 117 |
| Totals | |
|---|---|
| Change from base Build 11289977798: | 0.1% |
| Covered Lines: | 124798 |
| Relevant Lines: | 162237 |
