PowerDNS
auth: allow turning off across-zone resolving
Short description
Addresses #10017. Introduces new setting resolve-across-zones. Default is the unchanged behaviour.
Turning off the new setting causes CNAME targets to not be followed across (local) zones. Also, queries that could be answered by following a local delegation are similarly not resolved.
Checklist
I have:
- [x] read the CONTRIBUTING.md document
- [x] compiled this code
- [x] tested this code
- [x] included documentation (including possible behaviour changes)
- [ ] documented the code
- [x] added or modified regression test(s)
- [ ] added or modified unit test(s)
Pull Request Test Coverage Report for Build 11912910478
Details
- 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
- 104 unchanged lines in 14 files lost coverage.
- Overall coverage decreased (-0.02%) to 64.663%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pdns/packethandler.cc | 5 | 9 | 55.56% |
| <!-- | Total: | 6 | 10 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/recursordist/syncres.cc | 1 | 79.51% |
| pdns/recursordist/sortlist.cc | 2 | 74.12% |
| pdns/recursordist/aggressive_nsec.cc | 2 | 66.1% |
| pdns/rcpgenerator.cc | 2 | 89.83% |
| pdns/remote_logger.cc | 3 | 54.26% |
| pdns/iputils.cc | 3 | 54.99% |
| pdns/recursordist/recpacketcache.hh | 3 | 89.55% |
| pdns/recursordist/rec-tcp.cc | 4 | 64.66% |
| pdns/dnsdistdist/dnsdist-carbon.cc | 6 | 61.89% |
| pdns/recursordist/rec-tcpout.cc | 6 | 50.79% |
| <!-- | Total: | 104 |
| Totals | |
|---|---|
| Change from base Build 11891742819: | -0.02% |
| Covered Lines: | 125733 |
| Relevant Lines: | 163612 |
💛 - Coveralls
what about SVCB?
Is there currently some code in PDNS to follow SVCB? SVCB ist quite different as the client application needs to perform the resolving. But IMO PDNS should not provide hints out of bailiwik, regardless if CNAME, DNAME, SVCB/HTTPS, NS ....
what about SVCB?
SVCB was taken care of by https://github.com/PowerDNS/pdns/issues/10521