pdns icon indicating copy to clipboard operation
pdns copied to clipboard

dnsdist: add support for a callback when a new tickets key is added

Open chbruyand opened this issue 1 year ago • 5 comments

Short description

Checklist

I have:

  • [ ] read the CONTRIBUTING.md document
  • [ ] compiled this code
  • [ ] tested this code
  • [ ] included documentation (including possible behaviour changes)
  • [ ] documented the code
  • [ ] added or modified regression test(s)
  • [ ] added or modified unit test(s)
  • [ ] checked that this code was merged to master

chbruyand avatar Jun 14 '24 15:06 chbruyand

Pull Request Test Coverage Report for Build 9518942957

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2016 unchanged lines in 68 files lost coverage.
  • Overall coverage decreased (-1.7%) to 62.987%

Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/cachecleaner.hh 1 75.63%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/ws-api.cc 2 84.91%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.32%
pdns/views.hh 2 80.0%
pdns/channel.hh 2 51.75%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 73.63%
<!-- Total: 2016
Totals Coverage Status
Change from base Build 9498441929: -1.7%
Covered Lines: 41757
Relevant Lines: 59509

💛 - Coveralls

coveralls avatar Jun 14 '24 16:06 coveralls

Pull Request Test Coverage Report for Build 9697223695

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1850 unchanged lines in 53 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
<!-- Total: 0 22
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/aggressive_nsec.cc 2 66.39%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.5%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
<!-- Total: 1850
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84792
Relevant Lines: 112568

💛 - Coveralls

coveralls avatar Jun 27 '24 13:06 coveralls

Pull Request Test Coverage Report for Build 9697466876

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2065 unchanged lines in 64 files lost coverage.
  • Overall coverage increased (+1.3%) to 66.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
<!-- Total: 0 22
Files with Coverage Reduction New Missed Lines %
pdns/validate.cc 1 67.95%
pdns/recursordist/recursor_cache.cc 1 85.89%
pdns/epollmplexer.cc 2 81.88%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.5%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
<!-- Total: 2065
Totals Coverage Status
Change from base Build 9680344555: 1.3%
Covered Lines: 84615
Relevant Lines: 112618

💛 - Coveralls

coveralls avatar Jun 27 '24 13:06 coveralls

Pull Request Test Coverage Report for Build 9710022713

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1875 unchanged lines in 55 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.298%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
<!-- Total: 0 22
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/syncres.cc 1 79.71%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/epollmplexer.cc 2 83.13%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
pdns/channel.hh 2 53.26%
<!-- Total: 1875
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84837
Relevant Lines: 112579

💛 - Coveralls

coveralls avatar Jun 28 '24 09:06 coveralls

Pull Request Test Coverage Report for Build 9710133612

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1878 unchanged lines in 53 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
<!-- Total: 0 22
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/validate.cc 1 68.14%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.46%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
<!-- Total: 1878
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84812
Relevant Lines: 112579

💛 - Coveralls

coveralls avatar Jun 28 '24 09:06 coveralls

Pull Request Test Coverage Report for Build 9763102220

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2546 unchanged lines in 61 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.269%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 14 0.0%
<!-- Total: 0 23
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
<!-- Total: 2546
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84827
Relevant Lines: 112634

💛 - Coveralls

coveralls avatar Jul 02 '24 15:07 coveralls

Pull Request Test Coverage Report for Build 9773443469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2009 unchanged lines in 67 files lost coverage.
  • Overall coverage decreased (-1.5%) to 63.009%

Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/pollmplexer.cc 1 83.01%
pdns/cachecleaner.hh 2 75.25%
pdns/ws-api.cc 2 84.91%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.32%
pdns/ws-auth.cc 2 80.78%
pdns/channel.hh 2 51.75%
pdns/proxy-protocol.cc 2 73.63%
pdns/stubresolver.cc 3 77.58%
<!-- Total: 2009
Totals Coverage Status
Change from base Build 9762364246: -1.5%
Covered Lines: 41791
Relevant Lines: 59559

💛 - Coveralls

coveralls avatar Jul 03 '24 07:07 coveralls

Pull Request Test Coverage Report for Build 9776942173

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • 8596 unchanged lines in 89 files lost coverage.
  • Overall coverage decreased (-1.5%) to 62.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 14 0.0%
<!-- Total: 0 23
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 83.01%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 97.55%
pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc 2 0.0%
pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc 2 0.0%
pdns/ws-auth.cc 2 80.78%
pdns/channel.hh 2 45.89%
<!-- Total: 8596
Totals Coverage Status
Change from base Build 9762364246: -1.5%
Covered Lines: 104563
Relevant Lines: 144026

💛 - Coveralls

coveralls avatar Jul 03 '24 12:07 coveralls

Pull Request Test Coverage Report for Build 9777912267

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 5 files are covered.
  • 393 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-hooks.cc 13 15 86.67%
<!-- Total: 62 64
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 72.94%
pdns/sstuff.hh 2 56.83%
pdns/stubresolver.cc 3 77.58%
pdns/remote_logger.cc 3 54.26%
pdns/iputils.hh 3 78.53%
pdns/recursordist/test-syncres_cc1.cc 5 89.79%
pdns/signingpipe.cc 5 85.75%
pdns/recursordist/rec-tcp.cc 10 64.56%
pdns/misc.hh 29 87.62%
pdns/dnspacket.cc 60 71.51%
<!-- Total: 393
Totals Coverage Status
Change from base Build 9762364246: 0.2%
Covered Lines: 124829
Relevant Lines: 162181

💛 - Coveralls

coveralls avatar Jul 03 '24 13:07 coveralls

Pull Request Test Coverage Report for Build 9792847213

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 5 files are covered.
  • 414 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.1%) to 64.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-hooks.cc 13 15 86.67%
<!-- Total: 62 64
Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 66.76%
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/sstuff.hh 2 56.83%
pdns/backends/gsql/gsqlbackend.hh 2 96.57%
pdns/tcpiohandler.cc 2 66.77%
pdns/stubresolver.cc 3 77.58%
pdns/iputils.hh 3 78.57%
pdns/recursordist/test-syncres_cc1.cc 5 89.67%
pdns/iputils.cc 6 54.53%
<!-- Total: 414
Totals Coverage Status
Change from base Build 9762364246: 0.1%
Covered Lines: 124756
Relevant Lines: 162179

💛 - Coveralls

coveralls avatar Jul 04 '24 11:07 coveralls