pdns
pdns copied to clipboard
PowerDNS
Set nsec3param: first increase the serial and then rectify
Short description
fixes #14323
Checklist
I have:
- [x] read the CONTRIBUTING.md document
- [x] compiled this code
- [x] tested this code
- [ ] included documentation (including possible behaviour changes)
- [x] documented the code
- [ ] added or modified regression test(s)
- [ ] added or modified unit test(s)
Pull Request Test Coverage Report for Build 9498012098
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
- 5415 unchanged lines in 81 files lost coverage.
- Overall coverage decreased (-3.4%) to 61.22%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pdns/ws-auth.cc | 5 | 7 | 71.43% |
| <!-- | Total: | 5 | 7 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/webserver.hh | 1 | 69.16% |
| pdns/recursordist/ext/protozero/include/protozero/config.hpp | 1 | 0.0% |
| pdns/sstuff.hh | 1 | 59.53% |
| modules/gpgsqlbackend/gpgsqlbackend.cc | 1 | 88.62% |
| pdns/recursordist/sortlist.hh | 1 | 75.0% |
| pdns/dnstap.cc | 2 | 68.82% |
| ext/probds/murmur3.cc | 2 | 88.24% |
| pdns/backends/gsql/gsqlbackend.hh | 2 | 96.57% |
| pdns/dnsname.hh | 2 | 91.36% |
| pdns/opensslsigners.cc | 2 | 61.13% |
| <!-- | Total: | 5415 |
| Totals | |
|---|---|
| Change from base Build 9495982726: | -3.4% |
| Covered Lines: | 118803 |
| Relevant Lines: | 161528 |
💛 - Coveralls
Increasing the serial before rectify creates a race where a notify is sent before the zone is rectified. In backends with limited transaction support, like lmdb, this wil result in AXFR's of broken zones if disable-axfr-rectify is set. Since this is only fixing a cosmetic issue my suggestion is to leave the order as is. The propper way to fix this issue is to modify increase serial in such way that the original ordering information is preserved. This wil also fix #12677
Revoking my own approval after pondering upon https://github.com/PowerDNS/pdns/pull/14325#issuecomment-2488345511 which I had not noticed previously. Sorry about that.
