pdns icon indicating copy to clipboard operation
pdns copied to clipboard

`rec_control reload-acls` also should reload `proxy-protocol-from`

Open omoerbeek opened this issue 1 year ago • 1 comments

Discussed in https://github.com/PowerDNS/pdns/discussions/14086

Originally posted by franklouwers April 22, 2024 I was looking for a way to reload pdns_rec after a change has been made to proxy-protocol-from. I noticed rec_control reload-acls and was wondering if it should reload proxy-protocol-from?

At present it doesn't, however the internal variable to track proxy-protocol-from is called g_proxyProtocolACL, suggesting the devs at one point felt it's an ACL.

If it's an ACL, should it be reloaded bu reload-acls?

Also: we should decide if proxy-protocol-exceptions should get the same treatment.

omoerbeek avatar Apr 23 '24 12:04 omoerbeek

On the last question: I feel it should. It's a list of ips that deserve a special treatment and depending on if an ip is on the list or not, they might or might not get an answer, depending on how the question was asked. Sounds close enough to "an acl" to me.

franklouwers avatar Apr 26 '24 12:04 franklouwers