pdns icon indicating copy to clipboard operation
pdns copied to clipboard

GH Actions - Meson: Build auth using meson in `build-and-test-all`.

Open romeroalx opened this issue 10 months ago • 5 comments

Short description

Initial work as part of the tasks included in #13987 for building auth using Meson inside the build-and-test-all workflow.

Output binaries from the meson build are not installed but only generated (current ci-make-install step).

Checklist

I have:

  • [x] read the CONTRIBUTING.md document
  • [ ] compiled this code
  • [x] tested this code
  • [ ] included documentation (including possible behaviour changes)
  • [ ] documented the code
  • [ ] added or modified regression test(s)
  • [ ] added or modified unit test(s)
  • [ ] checked that this code was merged to master

romeroalx avatar Apr 05 '24 07:04 romeroalx

Pull Request Test Coverage Report for Build 8892092544

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 59.469%

Files with Coverage Reduction New Missed Lines %
pdns/iputils.hh 1 74.85%
pdns/pollmplexer.cc 1 82.39%
pdns/rcpgenerator.cc 2 90.05%
pdns/dnsdistdist/dnsdist.cc 2 68.36%
pdns/communicator.cc 3 71.85%
pdns/misc.cc 3 61.31%
pdns/auth-secondarycommunicator.cc 3 64.59%
pdns/recursordist/test-syncres_cc1.cc 5 89.71%
pdns/dnsdistdist/dnsdist-tcp.cc 5 76.05%
pdns/tcpiohandler.cc 10 66.85%
<!-- Total: 35
Totals Coverage Status
Change from base Build 8830304531: 0.02%
Covered Lines: 114204
Relevant Lines: 159430

💛 - Coveralls

coveralls avatar Apr 05 '24 08:04 coveralls

I had a short call with @romeroalx and we discussed moving more logic into tasks.py in a way that completely abstract build system internals from the user and from Github workflows.

fredmorcos avatar Apr 05 '24 11:04 fredmorcos

The systemd configure flag is added here: #14055

fredmorcos avatar Apr 10 '24 09:04 fredmorcos

The systemd configure flag is added here: #14055

That was merged. So this PR can now be merged after the systemd configure flag is enabled on meson.

fredmorcos avatar Apr 11 '24 14:04 fredmorcos

This branch has conflicts that must be resolved

Habbie avatar Apr 11 '24 14:04 Habbie