pdns icon indicating copy to clipboard operation
pdns copied to clipboard
verified publisher icon PowerDNS

dnsdist: Inconsistent casing in `DNSAction.Nxdomain` and `DNSRCode.NXDOMAIN`

Open rgacogne opened this issue 1 year ago • 3 comments

  • Program: dnsdist
  • Issue type: Bug report

Short description

It's impossible to get the correct version (Nxdomain, NXdomain, NXDomain, NXDOMAIN, ...) right without looking at the documentation, which is terrible. It would be nice to be consistent about it, and to warn when the wrong version is used if possible.

rgacogne avatar Feb 09 '24 12:02 rgacogne

You forgot my favorite: NxDomain! :-/

omoerbeek avatar Feb 09 '24 14:02 omoerbeek

If you want some Lua metatable magic to give smart warnings (could even do a case insensitive search in that case), let me know what behaviour you'd like.

Habbie avatar Mar 07 '24 18:03 Habbie

If I'm reading https://github.com/PowerDNS/pdns/blob/master/pdns/lua-base4.cc#L247 right, the authoritative server and the recursor use the all caps version, so perhaps it would make sense to do that as well?

rgacogne avatar Mar 08 '24 08:03 rgacogne