Change home directory to /var/lib/pdns
Check: https://bugzilla.redhat.com/show_bug.cgi?id=2262487
Fedora commit: https://src.fedoraproject.org/rpms/pdns/c/d6ae698064802c03bcf923cc0f97b02ddc2ee5c9?branch=rawhide
Pull Request Test Coverage Report for Build 8781625001
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 757 unchanged lines in 28 files lost coverage.
- Overall coverage increased (+13.1%) to 72.618%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pdns/dnsname.hh | 1 | 90.98% |
| pdns/tcpiohandler.cc | 1 | 66.98% |
| pdns/misc.cc | 1 | 61.59% |
| ext/json11/json11.cpp | 2 | 64.49% |
| pdns/recursordist/rec-tcp.cc | 2 | 4.94% |
| pdns/iputils.hh | 2 | 74.8% |
| ext/yahttp/yahttp/reqresp.cpp | 2 | 47.84% |
| pdns/dnsdistdist/dnsdist-async.cc | 2 | 82.21% |
| pdns/query-local-address.cc | 3 | 80.85% |
| pdns/dnsdistdist/dnsdist-tcp.cc | 4 | 75.43% |
| <!-- | Total: | 757 |
| Totals | |
|---|---|
| Change from base Build 8483175376: | 13.1% |
| Covered Lines: | 30212 |
| Relevant Lines: | 39051 |
💛 - Coveralls
want to do pdns-recursor.spec and dnsdist.spec too?
Looks ready for a merge apart from the whitespace spotted by Otto. Shall I fix it?
Looks ready for a merge apart from the whitespace spotted by Otto. Shall I fix it?
done
want to do pdns-recursor.spec and dnsdist.spec too?
there's also this, but that does not prevent merging
because of the observation in https://github.com/PowerDNS/pdns/pull/14083#issuecomment-2088536189 I am removing the backport labels
I have now come to my senses and realise that this patch still makes sense for first installs. I'll put the labels back :clown_face: