pdns icon indicating copy to clipboard operation
pdns copied to clipboard

Published 20 hours ago • verified publisher icon PowerDNS

tinydnsbackend AXFR is not tested, and was broken in 4.7

Open Habbie opened this issue 2 years ago • 4 comments

While investigating #12083, @cyclops1982 found that AXFR does not work at all in current master, with tinydnsbackend. Apparently we completely broke that somewhere after 4.5.3. We should add tests, and, of course, fix AXFR.

Habbie avatar Oct 17 '22 21:10 Habbie

I think https://github.com/PowerDNS/pdns/commit/8a66a9272451eb8b0daed88d8f1db5193c6c154e#diff-fe1471ab3ed6d3a679798abf6fc90082c79b169890d6489734ea5faf149490f4 change the behaviour.

cyclops1982 avatar Oct 18 '22 11:10 cyclops1982

I think 8a66a92#diff-fe1471ab3ed6d3a679798abf6fc90082c79b169890d6489734ea5faf149490f4 change the behaviour.

Which means it's broken since 4.7

Habbie avatar Oct 18 '22 18:10 Habbie

AXFR is fixed in #12097

Habbie avatar Oct 19 '22 15:10 Habbie

Setting tinydns-locations=no returns all records with a location in AXFR and in a normal query. This effectively skips the checking of the location alltogether.

cyclops1982 avatar Oct 21 '22 19:10 cyclops1982