pdns icon indicating copy to clipboard operation
pdns copied to clipboard

[tsan] add data race suppression for avg_latency and send_latencyres …

Open darnuria opened this issue 2 years ago • 1 comments

Attempt to add suppression for data races on send_latency and avg_latency globals. see discussion here #11814

darnuria avatar Aug 02 '22 21:08 darnuria

First time committed a tsan supp. I have seen that a change in https://github.com/PowerDNS/pdns/blob/master/.github/workflows/build-and-test-all.yml may be required but never committed Github workflow thing.

darnuria avatar Aug 02 '22 21:08 darnuria

@rgascogne have to make a rebase/squash or you you do the rollup? :)

darnuria avatar Aug 16 '22 13:08 darnuria

I'm not sure why the CI keeps failing on this one. Would you mind rebasing on master and squashing while you are at it? :)

rgacogne avatar Aug 17 '22 14:08 rgacogne

Got something like:

Check failure on line 347 in pdns/dnsdist-console.cc

Code scanning / CodeQL

Uncontrolled data used in path expression High
This argument to a file access function is derived from
and then passed to std::basic_ifstream>::basic_ifstream(__s)
This argument to a file access function is derived from and then passed to std::basic_ifstream>::basic_ifstream(__s), which calls std::basic_ifstream>::open(__s)
This argument to a file access function is derived from and then passed to std::basic_ifstream>::basic_ifstream(__s), which calls std::basic_ifstream>::open(__s), which calls std::basic_filebuf>::open(__s) 

And Check failure on line 353 in pdns/dnsdist-console.cc

Code scanning / CodeQL

Uncontrolled data used in path expression High
This argument to a file access function is derived from
and then passed to std::basic_ofstream>::basic_ofstream(__s), which calls std::basic_ofstream>::open(__s), which calls std::basic_filebuf>::open(__s)
This argument to a file access function is derived from and then passed to std::basic_ofstream>::basic_ofstream(__s)
This argument to a file access function is derived from and then passed to std::basic_ofstream>::basic_ofstream(__s), which calls std::basic_ofstream>::open(__s)

And something ... without log in Run inv test-auth-backend -b authpy.

Done squash + rebase. Wait and see. :eyes:

darnuria avatar Aug 18 '22 15:08 darnuria

Thanks!

rgacogne avatar Aug 19 '22 07:08 rgacogne