pdns-builder icon indicating copy to clipboard operation
pdns-builder copied to clipboard

Changes to the imagename

Open pieterlexis opened this issue 6 years ago • 4 comments

  • Add -t option to specify image tag name
  • Add -T option to specify image tag version, 'latest' by default. Can be set to 'version' to use $BUILDER_VERSION, used verbatim otherwise
  • Clean up usage by categorizing options
  • Sort the options in the getopts call and for statement

pieterlexis avatar Sep 24 '19 21:09 pieterlexis

Tag images as builder-$repo-$target:$BUILDER_VERSION by default

I don't think this is a good idea. If you do this, builds will never be removed by the docker cleanup script, while simply using :latest by default will ensure that the previous build becomes untagged.

This should really be an opt-in thing.

wojas avatar Sep 25 '19 04:09 wojas

This should really be an opt-in thing.

Fixed in the latest commit

pieterlexis avatar Sep 25 '19 07:09 pieterlexis

This branch has conflicts that must be resolved.

Habbie avatar Jan 26 '21 18:01 Habbie

Is this still needed?

aerique avatar Jul 04 '23 14:07 aerique