[1.18][Bug]: BYGVillagerTrades.appendTradesList() will cause java.lang.UnsupportedOperationException

[qzwxsaedc]

BYG Version

1.4.7

Terrablender Version

1.2.0.126

Mod Loader

Forge

Mod Loader Version

40.2.5

Bug Severity

Major

What happened?

https://github.com/AOCAWOL/BYG/blob/06a172b09722b743e9af1e82d8197fa2c41b79f7/Common/src/main/java/potionstudios/byg/common/entity/npc/BYGVillagerTrades.java#L131-L133

this method modifies the elements of a collection as it traverses it and will cause crash.

latest.log

https://gist.github.com/qzwxsaedc/282226e0cb3e7d2f39e14813f435eb5c

Did you isolate BYG?

I tried BYG alone

Did you read and understand the above agreement?

• [X] I agree.