postgrest icon indicating copy to clipboard operation
postgrest copied to clipboard

Add Coverage Overlay

Open wolfgangwalther opened this issue 5 years ago • 2 comments

As discussed in https://github.com/PostgREST/postgrest/pull/1694#discussion_r549840741, I'm splitting up the overlay into another PR. We need to increase our overall coverage by a fair bit, before merging this.

wolfgangwalther avatar Dec 29 '20 22:12 wolfgangwalther

For future reference. Code coverage can show some lines as unused, even though they are used. We had the following cases:

  • deriving ...: https://gitlab.haskell.org/ghc/ghc/-/issues/17155:

    So, unless you explicitly call every methods of Ord, deriving Ord is marked as never executed.

    • Example of this happening: https://github.com/PostgREST/postgrest/pull/2027#discussion_r751949108
  • Using RecordWildCards will not mark record fields as used: https://gitlab.haskell.org/ghc/ghc/-/issues/17834

wolfgangwalther avatar Nov 19 '21 08:11 wolfgangwalther

Just a note for posteriority: make the InternalError(https://github.com/PostgREST/postgrest/pull/2270#issuecomment-1115463986) not reduce coverage.

steve-chavez avatar May 03 '22 01:05 steve-chavez