fix: correctly constrain height
splitting out safe steps from https://github.com/PostHog/posthog/pull/42358
we have visual regression tests from further down the stack
so we can fix the height wrapping and see that we fixed it
- #43314

- #42906
đ (View in Graphite) - #42902

- #42897

- #42854
: 1 other dependent PR (#42871
) - #42836

- #42831

- #42821

- #42819

- #42815

master
This stack of pull requests is managed by Graphite. Learn more about stacking.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
Size Change: 0 B
Total Size: 3.7 MB
âšī¸ View Unchanged
| Filename | Size |
|---|---|
frontend/dist/toolbar.js |
3.7 MB |
âī¸ Skipped snapshot commit because branch advanced to 65702d6 while workflow was testing 2a9ae8e.
The new commit will trigger its own snapshot update workflow.
If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
- Merge master into your branch, or
- Push an empty commit:
git commit --allow-empty -m 'trigger CI' && git push
Visual regression: Storybook UI snapshots updated
Changes: 2 snapshots (2 modified, 0 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering
Visual regression: Storybook UI snapshots updated
Changes: 12 snapshots (0 modified, 12 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering
Visual regression: Storybook UI snapshots updated
Changes: 8 snapshots (8 modified, 0 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering
Visual regression: Storybook UI snapshots updated
Changes: 10 snapshots (0 modified, 10 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering
Visual regression: Storybook UI snapshots updated
Changes: 4 snapshots (4 modified, 0 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering