posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix: correctly constrain height

Open pauldambra opened this issue 2 weeks ago â€ĸ 5 comments

splitting out safe steps from https://github.com/PostHog/posthog/pull/42358

we have visual regression tests from further down the stack

so we can fix the height wrapping and see that we fixed it

pauldambra avatar Dec 07 '25 14:12 pauldambra

  • #43314 Graphite
  • #42906 Graphite 👈 (View in Graphite)
  • #42902 Graphite
  • #42897 Graphite
  • #42854 Graphite: 1 other dependent PR (#42871 Graphite)
  • #42836 Graphite
  • #42831 Graphite
  • #42821 Graphite
  • #42819 Graphite
  • #42815 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

pauldambra avatar Dec 07 '25 14:12 pauldambra

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Size Change: 0 B

Total Size: 3.7 MB

â„šī¸ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.7 MB

compressed-size-action

github-actions[bot] avatar Dec 07 '25 14:12 github-actions[bot]

â­ī¸ Skipped snapshot commit because branch advanced to 65702d6 while workflow was testing 2a9ae8e.

The new commit will trigger its own snapshot update workflow.

If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:

  • Merge master into your branch, or
  • Push an empty commit: git commit --allow-empty -m 'trigger CI' && git push

posthog-bot avatar Dec 07 '25 14:12 posthog-bot

Visual regression: Storybook UI snapshots updated

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot avatar Dec 07 '25 14:12 posthog-bot

Visual regression: Storybook UI snapshots updated

Changes: 12 snapshots (0 modified, 12 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot avatar Dec 11 '25 11:12 posthog-bot

Visual regression: Storybook UI snapshots updated

Changes: 8 snapshots (8 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot avatar Dec 11 '25 13:12 posthog-bot

Visual regression: Storybook UI snapshots updated

Changes: 10 snapshots (0 modified, 10 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot avatar Dec 11 '25 16:12 posthog-bot

Visual regression: Storybook UI snapshots updated

Changes: 4 snapshots (4 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current rendering
  • Next CI run will switch to CHECK mode to verify stability
  • If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

  • Review the changes to ensure they're intentional
  • Approve if changes match your expectations
  • If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot avatar Dec 11 '25 19:12 posthog-bot

Merge activity

  • Dec 12, 5:36 PM UTC: @pauldambra merged this pull request with Graphite.

pauldambra avatar Dec 12 '25 17:12 pauldambra