fix(expeirments): Adjust interval bar color
Problem
From feedback, it's currently not obvious when a variant result is significant since the confidence/credible interval bars are always colored.
Changes
Gray out the interval bars for non-significant results, only showing red/green coloring when the result is statistically significant. This is how competing tools do it too.
Size Change: 0 B
Total Size: 3.7 MB
ℹ️ View Unchanged
| Filename | Size |
|---|---|
frontend/dist/toolbar.js |
3.7 MB |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.
@andehen picking this up again. Made some tweaks based on our discussion:
- Frequentist non-significant results show a grey bar
- Bayesian non-significant results still show green/red colors, but faded
- When significant, the cell has colored background
I kinda like it, the cell perhaps is a bit too prominent for me. Happy to iterate further on this.
Yes, I remember now! Added the column, I quite like it :)
Visual regression: Storybook UI snapshots updated
Changes: 17 snapshots (17 modified, 0 added, 0 deleted)
What this means:
- Snapshots have been automatically updated to match current rendering
- Next CI run will switch to CHECK mode to verify stability
- If snapshots change again, CHECK mode will fail (indicates flapping)
Next steps:
- Review the changes to ensure they're intentional
- Approve if changes match your expectations
- If unexpected, investigate component rendering