posthog icon indicating copy to clipboard operation
posthog copied to clipboard

fix(experiments): Update link with the latest fragment in experiment release condition dialog

Open lshaowei18 opened this issue 7 months ago • 2 comments

[!IMPORTANT] 👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

In the dialog, clicking on the link does not scroll to the section that was intended:

https://github.com/user-attachments/assets/55b67e7b-88e6-4e45-8bbc-b7bfc3b32633

Changes

Updated the url with the latest fragment.

Did you write or update any docs for this change?

  • [ ] I've added or updated the docs
  • [ ] I've reached out for help from the docs team
  • [x] No docs needed for this change

How did you test this code?

Tested locally:

https://github.com/user-attachments/assets/27ff778e-0854-408e-8228-2f7feca4d73f

lshaowei18 avatar May 26 '25 01:05 lshaowei18

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jun 02 '25 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jun 16 '25 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jun 25 '25 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

posthog-bot avatar Jul 04 '25 07:07 posthog-bot

Hmmm im not sure why the visual test is failing, I don't think this PR consist of any UI updates.

lshaowei18 avatar Jul 07 '25 23:07 lshaowei18