PostHog
fix(quick start): Send user to install screen when clicking on ingest first event
Problem
Attempt to close https://github.com/PostHog/posthog/issues/32032
The behavior for /onboarding/product_analytics seems to be that it will remember the user's last visited step.
When a user first signs up for posthog, they are very likely to complete all the steps, ending at the invite_teammates step.
As a result, when they are routed to /onboarding/product_analytics, they will see the invite_teammates step.
Changes
- Specify the exact step that makes the most sense when routing, which is
install.
Does this work well for both Cloud and self-hosted?
I think it shouldn't have an impact.
How did you test this code?
Still trying to setup my local, so unable to test for now. If there are other ways to test it, please let me know and i will do the testing!
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.
Hmmmm I don't think the tests are failing because of these changes; but let me know if there is anything I can do to pass the tests!
@ishaowei18 I think the enum here needs to be moved out of the logic to avoid importing this logic into the sidepanel one - that should fix the jest tests :)
@ishaowei18 I think the enum here needs to be moved out of the logic to avoid importing this logic into the sidepanel one - that should fix the jest tests :)
Ah! Thanks, i will mark as draft and try to fix them, thank you :)
@joshsny thanks for the tip; appreciate it! Seems like the tests are passing :)